-
Notifications
You must be signed in to change notification settings - Fork 0
adjust help message #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 1.2.1 | ||
| ++++++ | ||
| * Update help messages | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎
Nothing to return.
| help='The identifier of the resource.') | ||
| c.argument('association_name', options_list=['--name', '-n'], help='The name of the association.') | ||
| c.argument('description', help='Description of the association.') | ||
| c.argument('description', help='Description of the association.For more message, please check: https:learn.microsoft.com/en-us/cli/azure/monitor/data-collection/endpoint/association?view=azure-cli-latest#az-monitor-data-collection-endpoint-association-list') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎
-
The URL is incomplete. It should be
https://learn.microsoft.com/en-us/cli/azure/monitor/data-collection/endpoint/association?view=azure-cli-latest#az-monitor-data-collection-endpoint-association-list. -
The placeholder
<resource/monitor/endpoint_id>should be enclosed in backticks for clarity and compliance with markdown formatting.
| @@ -1,7 +1,11 @@ | |||
| .. :changelog: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎
PR Summary:
- Updated help messages in the code.
- Changed the description argument to include a link for more information.
- Specified the format for the
endpoint_idargument. - Bumped the version from
1.2.0to1.2.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (Azure#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * refactor: add apic api update example * tests: add test case * fix: fix style * fix: fix test case * fix: fix test case * fix: fix test case & add recording * fix: remove bad command prefix * refactor: optimize test case code * refactor: remove duplicate example for apic create * fix: fix style * feat: add examples for create & update apic service with system assigned identity * fix: fix external doc extracting bug in spec * fix: remove extra print * fix: fix style * fix: fix style * fix: fix style * fix: fix style * tests: fix test case * refactor: remove external docs from tags * tests: update test case * refactor: remove summary setting in api register * feat: support custom metadata export only * fix: fix test case * tests: add test case * fix: fix arg type * refactor: add help example * fix: fix bad logic of link format * refactor: remove extra example * refactor: update example * doc: update 1.0.1 release history * refactor: change note style * fix: fix * fix: remove breaking change label * build: bump version to 1.1.0 * Update V1.1.0 history (Azure#71) * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst --------- Co-authored-by: Julia Kasper <[email protected]> * test: fix test cases * build: remove files to get ready for release --------- Co-authored-by: Chaoyi Yuan <[email protected]> Co-authored-by: Julia Kasper <[email protected]>
* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (Azure#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * feat: enable openapi spec from url in api register (Azure#74) * feat: enable openapi spec from url in api register * refactor: set spec definition as link format when link provided * fix: fix style * test: add error handling case for testing invalid spec url * fix: fix test case * fix: use 404 response url * test: update case * test: update test case * refactor: update error logic * test: update test case to setup live test pipeline (Azure#76) * test: update test case to setup live test pipeline (Azure#75) * test: update test case * update * . * . * . * . * . * . * . * . * . * . * . * test: update test case * refactor: enable both identity * fix: bad if else * fix: fix bad parameter * refactor: add example (Azure#77) * refactor: add example * fix: update params * fix: bad api id * refactor: add @filename.json examples (Azure#78) * refactor: add example * fix: update params * fix: bad api id * refactor: add @filename.json examples * refactor: update * refactor: add error handling (Azure#79) * refactor: add error handling * refactor: catch internal error * fix: revert the change * feat: support APIM/APIC sync (Azure#80) * feat: add APIM/APIC sync commands * feat: rename apim to azure-api-management * style: fix code style * fix: sync property names with new API spec * Revert "fix: sync property names with new API spec" This reverts commit 04da67e. --------- Co-authored-by: frankqianms <[email protected]> * feat: resolve feedback and fix examples (Azure#82) * feat: resolve feedback and fix examples * style: fix code style * feat: amazon api gateway sync (Azure#81) * feat: add APIM/APIC sync commands * feat: rename apim to azure-api-management * style: fix code style * fix: sync property names with new API spec * feat: add aws api gateway sync command * Revert "fix: sync property names with new API spec" This reverts commit 04da67e. * refactor: add amazonApiGatewaySource * refactor: refactoring apim sync and amazon sync * refactor: refactor cmd structure to make apim and aws sync seperated * fix: remove log print * chore: generate new cmds * refactor: update version and remove import * feat: add `apic integration create amazon-api-gateway` * fix: style * fix: change query param api-version * revert changes in _delete.py * fix: some neede fixs * fix: add the help sentence * refactor: make params clear * refactor: handle msi-resource-id * refacor: revert flatten of apim resource * fix: use 06-01-preiew currently * fix: style * refactor: arg groups * fix: bad short param name * chore: re-generate * fix: old resource_id name * chore: arg group * chore: naming * fix: fix according to comments * chore: update * fix: style --------- Co-authored-by: Chaoyi Yuan <[email protected]> * feat: add import amazon-api-gateway cmd (Azure#83) * feat: add import amazon-api-gateway cmd * feat: change arg group and update parameter name --------- Co-authored-by: Chaoyi Yuan <[email protected]> * fix: use older version API (Azure#84) * feat: rename command and param names (Azure#85) * feat: rename command and param names * doc: update comments * doc: update sample * test: add test case for sync cmd `apic integration create apim` and `apic integration create aws` (Azure#86) * test: add test case for apim sync * refactor: refactor for apim preparer * refactor: refactoring case and utils, optimize checkers * chore: remove print and add explaination * refactor: rename file * fix: try to fix error determing the version * revert: Remove specific azure-cli and azure-core installations * test: add aws sync testcase (Azure#87) * test: add test case for aws sync command * fix: remove key value * fix: remove pip install * chore: renaming constants * refactor: update the utils and test case * refactor: updated * fix: workaround for urllib3 package (Azure#88) * Revert "fix: workaround for urllib3 package (Azure#88)" (Azure#90) This reverts commit 1d508f4. * build: 1.2.0 beta 1 release * build: remove CI and CD files * doc: improve history * fix: set extention version to be preview * refactor: integration examples and bad example for `apic update` (Azure#91) * refactor: integration examples * fix: apic update example * chore: update log * test: add import-aws case and modify region --------- Co-authored-by: Chaoyi Yuan <[email protected]> Co-authored-by: Chaoyi Yuan <[email protected]>
7059eb5 to
3ab770e
Compare
* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (Azure#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * feat: enable openapi spec from url in api register (Azure#74) * feat: enable openapi spec from url in api register * refactor: set spec definition as link format when link provided * fix: fix style * test: add error handling case for testing invalid spec url * fix: fix test case * fix: use 404 response url * test: update case * test: update test case * refactor: update error logic * test: update test case to setup live test pipeline (Azure#76) * test: update test case to setup live test pipeline (Azure#75) * test: update test case * update * . * . * . * . * . * . * . * . * . * . * . * test: update test case * refactor: enable both identity * fix: bad if else * fix: fix bad parameter * refactor: add example (Azure#77) * refactor: add example * fix: update params * fix: bad api id * refactor: add @filename.json examples (Azure#78) * refactor: add example * fix: update params * fix: bad api id * refactor: add @filename.json examples * refactor: update * refactor: add error handling (Azure#79) * refactor: add error handling * refactor: catch internal error * fix: revert the change * feat: support APIM/APIC sync (Azure#80) * feat: add APIM/APIC sync commands * feat: rename apim to azure-api-management * style: fix code style * fix: sync property names with new API spec * Revert "fix: sync property names with new API spec" This reverts commit 04da67e. --------- Co-authored-by: frankqianms <[email protected]> * feat: resolve feedback and fix examples (Azure#82) * feat: resolve feedback and fix examples * style: fix code style * feat: amazon api gateway sync (Azure#81) * feat: add APIM/APIC sync commands * feat: rename apim to azure-api-management * style: fix code style * fix: sync property names with new API spec * feat: add aws api gateway sync command * Revert "fix: sync property names with new API spec" This reverts commit 04da67e. * refactor: add amazonApiGatewaySource * refactor: refactoring apim sync and amazon sync * refactor: refactor cmd structure to make apim and aws sync seperated * fix: remove log print * chore: generate new cmds * refactor: update version and remove import * feat: add `apic integration create amazon-api-gateway` * fix: style * fix: change query param api-version * revert changes in _delete.py * fix: some neede fixs * fix: add the help sentence * refactor: make params clear * refactor: handle msi-resource-id * refacor: revert flatten of apim resource * fix: use 06-01-preiew currently * fix: style * refactor: arg groups * fix: bad short param name * chore: re-generate * fix: old resource_id name * chore: arg group * chore: naming * fix: fix according to comments * chore: update * fix: style --------- Co-authored-by: Chaoyi Yuan <[email protected]> * feat: add import amazon-api-gateway cmd (Azure#83) * feat: add import amazon-api-gateway cmd * feat: change arg group and update parameter name --------- Co-authored-by: Chaoyi Yuan <[email protected]> * fix: use older version API (Azure#84) * feat: rename command and param names (Azure#85) * feat: rename command and param names * doc: update comments * doc: update sample * test: add test case for sync cmd `apic integration create apim` and `apic integration create aws` (Azure#86) * test: add test case for apim sync * refactor: refactor for apim preparer * refactor: refactoring case and utils, optimize checkers * chore: remove print and add explaination * refactor: rename file * fix: try to fix error determing the version * revert: Remove specific azure-cli and azure-core installations * test: add aws sync testcase (Azure#87) * test: add test case for aws sync command * fix: remove key value * fix: remove pip install * chore: renaming constants * refactor: update the utils and test case * refactor: updated * fix: workaround for urllib3 package (Azure#88) * Revert "fix: workaround for urllib3 package (Azure#88)" (Azure#90) This reverts commit 1d508f4. * build: 1.2.0 beta 1 release * build: remove CI and CD files * doc: improve history * fix: set extention version to be preview * refactor: integration examples and bad example for `apic update` (Azure#91) * refactor: integration examples * fix: apic update example * feat: add api-analysis rules (Azure#89) * feat: analysi rule init * feat: add create cmd * feat: add create and delete api-analysis commands * feat: add import-ruleset and export-ruleset commands * fix: update aaz * fix: registered * fix: examples * fix: fix style * refactor: renaming * refactor: regenerate aaz * fix: fix codes * fix: fix logics * fix: style * fix: rename parameter service name * fix: change api-analysis status to preview * fix: integration list * refactor: modify examples * feat: analysi rule init * feat: add create cmd * feat: add create and delete api-analysis commands * feat: add import-ruleset and export-ruleset commands * fix: update aaz * fix: registered * fix: examples * fix: fix style * refactor: renaming * refactor: regenerate aaz * fix: fix codes * fix: fix logics * fix: style * fix: change api-analysis status to preview * fix: change short name of service name * fix: apic update example * fix: examples and default value * chore: example * fix: bad parameter short names * fix: downgrade api version * fix: set default workspace for list,show,update api-analysis * refactor: integration examples * fix: style * chore: update log * test: add import-aws case and modify region * feat: add import apim and deperacate import-from-apim, add analysis create and list test cases * fix: correctly deprecate import-from-apim * test: add apianalysis test cases * build: bump up to 1.2.0b2 * test: add api-analysis update testcase * build: change log of 1.2.0b2 * chore: unregister the filter * fix: better methods name and remove extra lint disable * refactor: set default analyzer-type in aaz * refactor: remove preview tag for some integration commands and hide the analyzer_type param * chore: update spec for filter param * fix: set default analyzer_type correctly * fix: import apim fix (Azure#92) * add CD * rename * upgrade upload-artifact * fix: fix missing apis param in import apim * fix: regenerate according to new spec * cd: remove cd file * test: update test cases * fix: fix spec version in register command * test: update test cases * test: update recordings * test: live test * fix: fix test cases of api analysis * fix: update recordings * fix: remove comment * fix: merge and align latest version * Update command_patches.py fix linter * fix: remove import cmds & preview tag of integrate cmds * test: remove uneeded test cases * fix: fix linter failures for auto generated params * test: update tests * Update HISTORY.rst * fix: remove extra yml * Update HISTORY.rst * test: update test cases and recordings * fix: fix cases --------- Co-authored-by: Chaoyi Yuan <[email protected]> Co-authored-by: Chaoyi Yuan <[email protected]>
* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (#17) * update release notes and version for connectedk8s cli extension (#18) * remove redundant test files specific to forked repo CI checks --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]>
* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <[email protected]> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <[email protected]> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]> * remove redundant test files --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: Vineeth Thumma <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]>
* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <[email protected]> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <[email protected]> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]> * remove hardcoded public ARM endpoint url for fairfax and mooncake (#24) * Bug Fix for FFX mcr url (#22) * [connectedk8s] update release notes and version (#26) * remove redundant test files * remove change not relevant to connectedk8s release --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: Vineeth Thumma <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]> Co-authored-by: hapate <[email protected]>
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.